Bug 187703 - Web Inspector: Fix execution highlighting after r233820
Summary: Web Inspector: Fix execution highlighting after r233820
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-16 10:41 PDT by Matt Baker
Modified: 2018-07-16 13:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.74 KB, patch)
2018-07-16 10:43 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-07-16 10:41:28 PDT 
Summary:
Fix execution highlighting after r233820. In https://webkit.org/b/187613, the arguments to TextEditor.prototype.getTextInRange were changed to SourceCodePosition instead of CodeMirror.Pos. A call site in SourceCodeTextEditor was missed.
Comment 1 Radar WebKit Bug Importer 2018-07-16 10:42:07 PDT 
<rdar://problem/42246167>
Comment 2 Matt Baker 2018-07-16 10:43:53 PDT 
Created attachment 345099 [details]
Patch
Comment 3 Joseph Pecoraro 2018-07-16 12:39:58 PDT 
Comment on attachment 345099 [details]
Patch

rs=me
Comment 4 WebKit Commit Bot 2018-07-16 13:06:59 PDT 
Comment on attachment 345099 [details]
Patch

Clearing flags on attachment: 345099

Committed r233861: <https://trac.webkit.org/changeset/233861>
Comment 5 WebKit Commit Bot 2018-07-16 13:07:01 PDT 
All reviewed patches have been landed.  Closing bug.