Bug 187690 - [iOS apps on macOS] Playing embedded Twitter videos in the News app crashes the web process
Summary: [iOS apps on macOS] Playing embedded Twitter videos in the News app crashes t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-15 19:27 PDT by Wenson Hsieh
Modified: 2018-07-17 15:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2018-07-15 19:52 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
ChangeLog tweak (2.60 KB, patch)
2018-07-15 20:15 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-07-15 19:27:27 PDT 
<rdar://problem/41869703>
Comment 1 Wenson Hsieh 2018-07-15 19:52:04 PDT 
Created attachment 345073 [details]
Patch
Comment 2 Wenson Hsieh 2018-07-15 20:15:04 PDT 
Created attachment 345075 [details]
ChangeLog tweak
Comment 3 Tim Horton 2018-07-15 21:51:46 PDT 
Comment on attachment 345075 [details]
ChangeLog tweak

Ha! This makes so much sense.
Comment 4 Wenson Hsieh 2018-07-15 21:53:03 PDT 
Comment on attachment 345075 [details]
ChangeLog tweak

Thanks for the review!
Comment 5 WebKit Commit Bot 2018-07-15 22:19:49 PDT 
Comment on attachment 345075 [details]
ChangeLog tweak

Clearing flags on attachment: 345075

Committed r233841: <https://trac.webkit.org/changeset/233841>
Comment 6 WebKit Commit Bot 2018-07-15 22:19:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Alexey Proskuryakov 2018-07-17 15:46:01 PDT 
Comment on attachment 345075 [details]
ChangeLog tweak

View in context: https://bugs.webkit.org/attachment.cgi?id=345075&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:97
> +#if PLATFORM(IOSMAC)

Why does the same issue not impact other configurations? It seems fragile that the only do the safe thing on IOSMAC.
Comment 8 Wenson Hsieh 2018-07-17 15:48:24 PDT 
(In reply to Alexey Proskuryakov from comment #7)
> Comment on attachment 345075 [details]
> ChangeLog tweak
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345075&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:97
> > +#if PLATFORM(IOSMAC)
> 
> Why does the same issue not impact other configurations? It seems fragile
> that the only do the safe thing on IOSMAC.

It doesn't impact macOS because we don't need to dynamically load iOS-only symbols there.

In this case (on iosmac), we were failing to link symbols in AudioSessionIOS, which is not compiled on macOS.