Bug 187634 - Signal.cpp's activeThreads() should only create its ThreadGroup once.
Summary: Signal.cpp's activeThreads() should only create its ThreadGroup once.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-12 22:34 PDT by Mark Lam
Modified: 2018-07-13 00:04 PDT (History)
14 users (show)

See Also:

Attachments
proposed patch. (1.62 KB, patch)
2018-07-12 22:40 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-07-12 22:34:07 PDT 
registerThreadForMachExceptionHandling() is relying on the activeThreads() ThreadGroup being a singleton.

<rdar://problem/40662311>
Comment 1 Mark Lam 2018-07-12 22:40:12 PDT 
Created attachment 344926 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2018-07-12 22:50:31 PDT 
Comment on attachment 344926 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2018-07-12 23:37:11 PDT 
Comment on attachment 344926 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 4 WebKit Commit Bot 2018-07-13 00:04:17 PDT 
Comment on attachment 344926 [details]
proposed patch.

Clearing flags on attachment: 344926

Committed r233795: <https://trac.webkit.org/changeset/233795>
Comment 5 WebKit Commit Bot 2018-07-13 00:04:19 PDT 
All reviewed patches have been landed.  Closing bug.