187573 – Make WebKit.LinkColorWithSystemAppearance work across system versions

Bug 187573 - Make WebKit.LinkColorWithSystemAppearance work across system versions

Summary: Make WebKit.LinkColorWithSystemAppearance work across system versions

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Timothy Hatcher

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2018-07-11 17:51 PDT by Timothy Hatcher
Modified:	2018-07-12 11:38 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (1.86 KB, patch) 2018-07-11 17:52 PDT, Timothy Hatcher	no flags	Details \| Formatted Diff \| Diff
Patch (2.06 KB, patch) 2018-07-12 10:30 PDT, Timothy Hatcher	no flags	Details \| Formatted Diff \| Diff
Patch (2.06 KB, patch) 2018-07-12 10:59 PDT, Timothy Hatcher	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Timothy Hatcher 2018-07-11 17:51:39 PDT

The [NSColor linkColor] is different between 10.14 and earlier macOS releases. Make this test work in all cases.

Comment 1 Timothy Hatcher 2018-07-11 17:52:59 PDT Comment hidden (obsolete)

Created attachment 344800 [details]
Patch

Comment 2 Wenson Hsieh 2018-07-12 08:28:14 PDT Comment hidden (obsolete)

Comment on attachment 344800 [details]
Patch

I might be missing something here, but it looks like +[NSColor linkColor] only exists in <AppKit/NSColor.h> on macOS Mojave (despite NS_AVAILABLE_MAC(10_10) in the header).

Comment 3 Wenson Hsieh 2018-07-12 08:32:58 PDT Comment hidden (obsolete)

(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 344800 [details]
> Patch
> 
> I might be missing something here, but it looks like +[NSColor linkColor]
> only exists in <AppKit/NSColor.h> on macOS Mojave (despite
> NS_AVAILABLE_MAC(10_10) in the header).

Ah, that being said, +[NSColor linkColor] is SPI in NSColor_Private.h on Sierra and High Sierra SDKs, where its availability is declared as NS_AVAILABLE_MAC(10_10).

I'm not sure if transferring the same availability over to the public header was an intentional change in Mojave...but it seems like we need to forward declare this to get it to build on the open source WebKit bots.

Comment 4 Timothy Hatcher 2018-07-12 08:47:58 PDT Comment hidden (obsolete)

Sigh, yep. We declare it in our NSColorSPI.h. I’ll just include that.

Comment 5 Timothy Hatcher 2018-07-12 10:30:58 PDT Comment hidden (obsolete)

Created attachment 344858 [details]
Patch

Comment 6 Timothy Hatcher 2018-07-12 10:59:19 PDT

Created attachment 344861 [details]
Patch

Comment 7 WebKit Commit Bot 2018-07-12 11:37:54 PDT

Comment on attachment 344861 [details]
Patch

Clearing flags on attachment: 344861

Committed r233775: <https://trac.webkit.org/changeset/233775>

Comment 8 WebKit Commit Bot 2018-07-12 11:37:56 PDT

All reviewed patches have been landed.  Closing bug.

Comment 9 Radar WebKit Bug Importer 2018-07-12 11:38:19 PDT

<rdar://problem/42130497>