Bug 187548 - [JSC] Thread VM& to JSCell::methodTable(VM&)
Summary: [JSC] Thread VM& to JSCell::methodTable(VM&)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-10 22:27 PDT by Yusuke Suzuki
Modified: 2018-07-12 01:44 PDT (History)
7 users (show)

See Also:

Attachments
Patch (42.50 KB, patch)
2018-07-10 22:29 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (42.47 KB, patch)
2018-07-10 22:30 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (42.48 KB, patch)
2018-07-10 22:55 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-07-10 22:27:51 PDT 
[JSC] Thread VM& to JSCell::methodTable(VM&)
Comment 1 Yusuke Suzuki 2018-07-10 22:29:15 PDT 
Created attachment 344752 [details]
Patch
Comment 2 Yusuke Suzuki 2018-07-10 22:30:03 PDT 
Created attachment 344753 [details]
Patch
Comment 3 Yusuke Suzuki 2018-07-10 22:55:15 PDT 
Created attachment 344756 [details]
Patch
Comment 4 Mark Lam 2018-07-11 09:30:22 PDT 
Comment on attachment 344756 [details]
Patch

nit: in all the functions, can you put VM& as the first argument instead of the last?  Thanks.
Comment 5 Yusuke Suzuki 2018-07-12 01:37:44 PDT 
(In reply to Mark Lam from comment #4)
> Comment on attachment 344756 [details]
> Patch
> 
> nit: in all the functions, can you put VM& as the first argument instead of
> the last?  Thanks.

These functions are a method in ClassInfo's MethodTable. So the first argument is used for the `thisObject` cell.
In our convention, we define arguments in the following order for MethodTable's method.

JSCell* thisObject, ExecState*, VM&, arguments...

So, in this case, I think `JSCell*, VM&` order is OK.
Comment 6 Yusuke Suzuki 2018-07-12 01:43:50 PDT 
Committed r233765: <https://trac.webkit.org/changeset/233765>
Comment 7 Radar WebKit Bug Importer 2018-07-12 01:44:18 PDT 
<rdar://problem/42110538>