Bug 187508 - Web Inspector: Remove unused NavigationSidebarPanel.treeElementAddedOrChanged
Summary: Web Inspector: Remove unused NavigationSidebarPanel.treeElementAddedOrChanged
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-09 23:24 PDT by Matt Baker
Modified: 2018-07-10 12:17 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.85 KB, patch)
2018-07-09 23:25 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews201 for win-future (12.76 MB, application/zip)
2018-07-10 06:49 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-07-09 23:24:04 PDT
Introduced way back in https://trac.webkit.org/r183821, but no longer needed since TimelineSidebarPanel no longer exists.
Comment 1 Matt Baker 2018-07-09 23:25:44 PDT
Created attachment 344672 [details]
Patch
Comment 2 EWS Watchlist 2018-07-10 06:49:08 PDT
Comment on attachment 344672 [details]
Patch

Attachment 344672 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8494033

New failing tests:
http/tests/security/local-video-source-from-remote.html
Comment 3 EWS Watchlist 2018-07-10 06:49:20 PDT
Created attachment 344692 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Joseph Pecoraro 2018-07-10 11:47:47 PDT
Comment on attachment 344672 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-07-10 12:15:06 PDT
Comment on attachment 344672 [details]
Patch

Clearing flags on attachment: 344672

Committed r233693: <https://trac.webkit.org/changeset/233693>
Comment 6 WebKit Commit Bot 2018-07-10 12:15:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-07-10 12:17:16 PDT
<rdar://problem/42034812>