Bug 187467 - [JSC] Make some data members of UnlinkedCodeBlock private
Summary: [JSC] Make some data members of UnlinkedCodeBlock private
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-09 06:33 PDT by Yusuke Suzuki
Modified: 2018-07-09 10:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.78 KB, patch)
2018-07-09 06:34 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-07-09 06:33:02 PDT 
[JSC] Make some data members of UnlinkedCodeBlock private
Comment 1 Yusuke Suzuki 2018-07-09 06:34:05 PDT 
Created attachment 344579 [details]
Patch
Comment 2 EWS Watchlist 2018-07-09 06:36:16 PDT 
Attachment 344579 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:374:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:375:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2018-07-09 09:59:11 PDT 
Comment on attachment 344579 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2018-07-09 10:09:48 PDT 
Committed r233645: <https://trac.webkit.org/changeset/233645>
Comment 5 Radar WebKit Bug Importer 2018-07-09 10:10:30 PDT 
<rdar://problem/41977825>