Bug 187466 - Avoid caching HLS 200 responses
Summary: Avoid caching HLS 200 responses
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-09 05:00 PDT by Antti Koivisto
Modified: 2022-10-10 10:05 PDT (History)
10 users (show)

See Also:

Attachments
patch (2.05 KB, patch)
2018-07-09 05:15 PDT, Antti Koivisto 		eric.carlson: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.78 MB, application/zip)
2018-07-09 06:53 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-07-09 05:00:24 PDT 
We don't want to cache streaming media even when it is marked cacheable to avoid churn. Currently some HLS streams may get cached.
Comment 1 Antti Koivisto 2018-07-09 05:01:01 PDT 
<rdar://problem/41910128>
Comment 2 Antti Koivisto 2018-07-09 05:15:00 PDT 
Created attachment 344578 [details]
patch

Will try to make a test.
Comment 3 EWS Watchlist 2018-07-09 06:53:04 PDT 
Comment on attachment 344578 [details]
patch

Attachment 344578 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8481948

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 4 EWS Watchlist 2018-07-09 06:53:15 PDT 
Created attachment 344581 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Ahmad Saleem 2022-10-10 10:05:46 PDT 
In this commit we disabled caching altogether for HLS:

https://github.com/WebKit/WebKit/commit/6f1aa1431a1df070526c2918a2332c6d53322ed1#diff-3e6ec4e4ac82410cffa7edc087fe8d45dd3babc8e8d164172e64f8ec3d5d6885

Do we need this anymore? Thanks!