RESOLVED FIXED 187425
Semantic colors don't update when accessibility Increase Contrast mode is enabled 
https://bugs.webkit.org/show_bug.cgi?id=187425
Summary Semantic colors don't update when accessibility Increase Contrast mode is ena...
Timothy Hatcher
Reported 2018-07-06 17:04:25 PDT
<rdar://problem/39948240>
Attachments
Patch (18.51 KB, patch)
2018-07-06 17:38 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (18.50 KB, patch)
2018-07-06 18:07 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-02 for mac-sierra (2.29 MB, application/zip)
2018-07-06 19:19 PDT, WebKit Commit Bot 		no flags
Details
Patch (23.18 KB, patch)
2018-07-09 15:18 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (23.98 KB, patch)
2018-07-09 15:22 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2018-07-06 17:38:06 PDT Comment hidden (obsolete)
Tim Horton
Comment 2 2018-07-06 18:01:20 PDT Comment hidden (obsolete)
Timothy Hatcher
Comment 3 2018-07-06 18:07:24 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 4 2018-07-06 19:19:07 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 5 2018-07-06 19:19:09 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 6 2018-07-06 20:42:22 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 7 2018-07-06 20:43:10 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 8 2018-07-06 20:43:12 PDT Comment hidden (obsolete)
Antti Koivisto
Comment 9 2018-07-07 06:23:00 PDT
Comment on attachment 344495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344495&action=review > Source/WebCore/page/Page.cpp:536 > + if (StyleResolver* styleResolver = document->styleScope().resolverIfExists()) > + styleResolver->invalidateMatchedPropertiesCache(); > + document->scheduleForcedStyleRecalc(); > + document->styleScope().didChangeStyleSheetEnvironment(); Only the last one of these should really be needed (the rest are harmless though).
Timothy Hatcher
Comment 10 2018-07-07 12:02:33 PDT
(In reply to Antti Koivisto from comment #9) > Comment on attachment 344495 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344495&action=review > > > Source/WebCore/page/Page.cpp:536 > > + if (StyleResolver* styleResolver = document->styleScope().resolverIfExists()) > > + styleResolver->invalidateMatchedPropertiesCache(); > > + document->scheduleForcedStyleRecalc(); > > + document->styleScope().didChangeStyleSheetEnvironment(); > > Only the last one of these should really be needed (the rest are harmless > though). They all seemed to be needed in my testing.
Truitt Savell
Comment 11 2018-07-09 08:34:28 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 12 2018-07-09 09:25:56 PDT Comment hidden (obsolete)
Timothy Hatcher
Comment 13 2018-07-09 15:18:55 PDT Comment hidden (obsolete)
Timothy Hatcher
Comment 14 2018-07-09 15:22:09 PDT
Created attachment 344626 [details] Patch
WebKit Commit Bot
Comment 15 2018-07-09 16:14:48 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 16 2018-07-09 16:15:00 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 17 2018-07-09 17:22:10 PDT
Comment on attachment 344626 [details] Patch Clearing flags on attachment: 344626 Committed r233670: <https://trac.webkit.org/changeset/233670>
WebKit Commit Bot
Comment 18 2018-07-09 17:22:12 PDT
All reviewed patches have been landed. Closing bug.
Truitt Savell
Comment 19 2018-07-10 08:39:31 PDT
After r233670 we are having the same api test failure on all platforms. Link to output of test failure: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/5539/steps/run-api-tests/logs/stdio excerpt: Test suite failed Failed TestWebKitAPI.WebKit.LinkColorWithSystemAppearance /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:56 Value of: linkColor Actual: "rgb(0, 105, 217)" Expected: "rgb(0, 104, 218)" It is good to note though that the actual and expected color is only off by one point this time.
Timothy Hatcher
Comment 20 2018-07-10 09:54:03 PDT
(In reply to Truitt Savell from comment #19) > After r233670 we are having the same api test failure on all platforms. > > Link to output of test failure: > https://build.webkit.org/builders/ > Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/5539/steps/run- > api-tests/logs/stdio > > excerpt: > Test suite failed > > Failed > > TestWebKitAPI.WebKit.LinkColorWithSystemAppearance > > > /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/ > WebKitCocoa/SystemColors.mm:56 > Value of: linkColor > Actual: "rgb(0, 105, 217)" > Expected: "rgb(0, 104, 218)" > > It is good to note though that the actual and expected color is only off by > one point this time. It seems this differs from macOS 10.14 and previous systems.
Ryan Haddad
Comment 21 2018-07-10 17:24:34 PDT
(In reply to Timothy Hatcher from comment #20) > (In reply to Truitt Savell from comment #19) > > After r233670 we are having the same api test failure on all platforms. > > > > Link to output of test failure: > > https://build.webkit.org/builders/ > > Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/5539/steps/run- > > api-tests/logs/stdio > > > > excerpt: > > Test suite failed > > > > Failed > > > > TestWebKitAPI.WebKit.LinkColorWithSystemAppearance > > > > > > /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/ > > WebKitCocoa/SystemColors.mm:56 > > Value of: linkColor > > Actual: "rgb(0, 105, 217)" > > Expected: "rgb(0, 104, 218)" > > > > It is good to note though that the actual and expected color is only off by > > one point this time. > > It seems this differs from macOS 10.14 and previous systems. Are we tracking a fix for this somewhere?
Note You need to log in before you can comment on or make changes to this bug.