Bug 187423 - Web Inspector: Dark Mode: resource search field has white text on white background
Summary: Web Inspector: Dark Mode: resource search field has white text on white backg...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-06 16:44 PDT by Nikita Vasilyev
Modified: 2018-07-06 17:44 PDT (History)
4 users (show)

See Also:

Attachments
[Image] Bug (10.96 KB, image/png)
2018-07-06 16:44 PDT, Nikita Vasilyev 		no flags Details
Patch (1.34 KB, patch)
2018-07-06 16:50 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Image] WIth patch applied (11.62 KB, image/png)
2018-07-06 16:51 PDT, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-07-06 16:44:41 PDT 
Created attachment 344484 [details]
[Image] Bug

The search field text is only visible when selected. The background of the search field should be gray.

<rdar://problem/41873913>
Comment 1 Nikita Vasilyev 2018-07-06 16:50:19 PDT 
Created attachment 344487 [details]
Patch
Comment 2 Nikita Vasilyev 2018-07-06 16:51:25 PDT 
Created attachment 344489 [details]
[Image] WIth patch applied
Comment 3 Nikita Vasilyev 2018-07-06 16:59:33 PDT 
(In reply to Nikita Vasilyev from comment #2)
> Created attachment 344489 [details]
> [Image] WIth patch applied

Note that the "x" and magnifying glass icons are still black. These are native to <input type=search> and should be fixed in WebKit (rdar://problem/41914972).
Comment 4 WebKit Commit Bot 2018-07-06 17:44:35 PDT 
Comment on attachment 344487 [details]
Patch

Clearing flags on attachment: 344487

Committed r233608: <https://trac.webkit.org/changeset/233608>
Comment 5 WebKit Commit Bot 2018-07-06 17:44:37 PDT 
All reviewed patches have been landed.  Closing bug.