Bug 187299 - Don't allow autoplay when the element is suspended
Summary: Don't allow autoplay when the element is suspended
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-03 13:40 PDT by Eric Carlson
Modified: 2018-07-05 12:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (9.38 KB, patch)
2018-07-03 14:13 PDT, Eric Carlson 		youennf: review+
Details | Formatted Diff | Diff
Patch for landing (9.32 KB, patch)
2018-07-03 14:33 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-07-03 13:40:17 PDT 
Don't allow autoplay when the element is suspended.
Comment 1 Eric Carlson 2018-07-03 13:41:47 PDT 
<rdar://problem/41044691>
Comment 2 Eric Carlson 2018-07-03 14:13:53 PDT 
Created attachment 344214 [details]
Patch
Comment 3 EWS Watchlist 2018-07-03 14:15:18 PDT 
Attachment 344214 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLMediaElement.cpp:286:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/HTMLMediaElement.cpp:302:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2018-07-03 14:33:18 PDT 
Created attachment 344218 [details]
Patch for landing
Comment 5 EWS Watchlist 2018-07-03 14:34:32 PDT 
Attachment 344218 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLMediaElement.cpp:286:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/HTMLMediaElement.cpp:302:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 WebKit Commit Bot 2018-07-03 15:57:22 PDT 
Comment on attachment 344218 [details]
Patch for landing

Clearing flags on attachment: 344218

Committed r233485: <https://trac.webkit.org/changeset/233485>