Bug 187215 - Generate event and event target interface types directly instead of via macros
Summary: Generate event and event target interface types directly instead of via macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-29 22:22 PDT by Ryosuke Niwa
Modified: 2018-07-02 15:55 PDT (History)
6 users (show)

See Also:

Attachments
Cleanup (19.46 KB, patch)
2018-06-29 22:45 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Cmake build fix attempt (21.52 KB, patch)
2018-06-29 23:58 PDT, Ryosuke Niwa 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-06-29 22:22:36 PDT 
Right now, make_event_factory.pl generates a bunch of macros in order to define EventInterface
and EventTargetInterface as well as toJS and toJSNewlyCreated.

Generate the final code directly to make debugging easier.
Comment 1 Ryosuke Niwa 2018-06-29 22:45:21 PDT 
Created attachment 343998 [details]
Cleanup
Comment 2 Ryosuke Niwa 2018-06-29 23:58:45 PDT 
Created attachment 344004 [details]
Cmake build fix attempt
Comment 3 Chris Dumez 2018-07-02 15:43:19 PDT 
Comment on attachment 344004 [details]
Cmake build fix attempt

View in context: https://bugs.webkit.org/attachment.cgi?id=344004&action=review

> Source/WebCore/ChangeLog:9
> +        and EventTargetInterface enum values and toJS for EventTarget. Removed the code to generate EvnentFactory::create

Typo: EvnentFactory
Comment 4 Ryosuke Niwa 2018-07-02 15:54:34 PDT 
Committed r233443: <https://trac.webkit.org/changeset/233443>
Comment 5 Radar WebKit Bug Importer 2018-07-02 15:55:24 PDT 
<rdar://problem/41745345>