Bug 187181 - Returning PiP'd video to fullscreen while playing leaves video muted.
Summary: Returning PiP'd video to fullscreen while playing leaves video muted.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-29 09:05 PDT by Jer Noble
Modified: 2018-06-29 17:44 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.28 KB, patch)
2018-06-29 09:13 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (7.36 KB, patch)
2018-06-29 09:21 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-06-29 09:05:57 PDT
Returning PiP'd video to fullscreen while playing leaves video muted.
Comment 1 Jer Noble 2018-06-29 09:06:16 PDT
<rdar://problem/41408335>
Comment 2 Jer Noble 2018-06-29 09:13:44 PDT
Created attachment 343915 [details]
Patch
Comment 3 Jer Noble 2018-06-29 09:21:27 PDT
Created attachment 343918 [details]
Patch
Comment 4 Eric Carlson 2018-06-29 09:23:41 PDT
Comment on attachment 343918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343918&action=review

> LayoutTests/media/picture-in-picture-interruption.html:34
> +    <div>This tests that video is in the correct media session state after enting a background interruption while pipped.</div>

Nit: "enting"
Comment 5 Jer Noble 2018-06-29 10:15:47 PDT
Committed r233360: <https://trac.webkit.org/changeset/233360>
Comment 6 Ryan Haddad 2018-06-29 17:25:39 PDT
media/picture-in-picture-interruption.html is timing out on iOS Simulator bots:

https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r233374%20(5903)/results.html
Comment 7 Ryan Haddad 2018-06-29 17:29:54 PDT
(In reply to Ryan Haddad from comment #6)
> media/picture-in-picture-interruption.html is timing out on iOS Simulator
> bots:
> 
> https://build.webkit.org/results/
> Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r233374%20(5903)/
> results.html
Oh, probably because of:
            runWithKeyDown(function(){ video.webkitSetPresentationMode('picture-in-picture'); });
Comment 8 Ryan Haddad 2018-06-29 17:44:26 PDT
Skipped test on iOS in https://trac.webkit.org/r233382.