Bug 187051 - REGRESSION(r233065): Build broken with clang-3.8 and libstdc++-5
Summary: REGRESSION(r233065): Build broken with clang-3.8 and libstdc++-5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks: 186896
  Show dependency tree / graph
 
Reported: 2018-06-26 10:22 PDT by Carlos Alberto Lopez Perez
Modified: 2018-06-26 11:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2018-06-26 10:28 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2018-06-26 10:22:55 PDT 
r233065: <https://trac.webkit.org/changeset/233065> broke our Ubuntu bot (Ubuntu 16.04: -> clang-3.8 with libstcd++-5.4)


./../Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:312:16: error: chosen constructor is explicit in copy-initialization
        return { profile, recommendedIndexingType };
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/tuple:612:19: note: constructor declared here
        constexpr tuple(_U1&& __a1, _U2&& __a2)
                  ^
1 error generated.


Log: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Ubuntu%20LTS%20%28Build%29/builds/13359/steps/compile-webkit/logs/stdio
Comment 1 Carlos Alberto Lopez Perez 2018-06-26 10:28:20 PDT 
Created attachment 343615 [details]
Patch
Comment 2 WebKit Commit Bot 2018-06-26 11:01:04 PDT 
Comment on attachment 343615 [details]
Patch

Clearing flags on attachment: 343615

Committed r233206: <https://trac.webkit.org/changeset/233206>
Comment 3 WebKit Commit Bot 2018-06-26 11:01:05 PDT 
All reviewed patches have been landed.  Closing bug.