Bug 186986 - Web Inspector: Dark Mode: Font guideline colors are too bright
Summary: Web Inspector: Dark Mode: Font guideline colors are too bright
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-24 20:03 PDT by Nikita Vasilyev
Modified: 2018-06-25 10:35 PDT (History)
4 users (show)

See Also:

Attachments
[Screenshot] Bug (112.55 KB, image/png)
2018-06-24 20:03 PDT, Nikita Vasilyev 		no flags Details
Patch (2.23 KB, patch)
2018-06-24 20:15 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Screenshot] With patch applied (104.67 KB, image/png)
2018-06-24 20:16 PDT, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-06-24 20:03:08 PDT 
Created attachment 343478 [details]
[Screenshot] Bug

For the dark mode, these colors should be more saturated and also darker.
Comment 1 Nikita Vasilyev 2018-06-24 20:15:38 PDT 
Created attachment 343479 [details]
Patch
Comment 2 Nikita Vasilyev 2018-06-24 20:16:03 PDT 
Created attachment 343480 [details]
[Screenshot] With patch applied
Comment 3 BJ Burg 2018-06-25 10:05:14 PDT 
Comment on attachment 343479 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-06-25 10:34:55 PDT 
Comment on attachment 343479 [details]
Patch

Clearing flags on attachment: 343479

Committed r233152: <https://trac.webkit.org/changeset/233152>
Comment 5 WebKit Commit Bot 2018-06-25 10:34:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-25 10:35:33 PDT 
<rdar://problem/41428776>