Bug 186881 - Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants.
Summary: Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emilio Cobos Álvarez (:emilio)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-21 01:41 PDT by Emilio Cobos Álvarez (:emilio)
Modified: 2018-06-27 02:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2018-06-21 01:45 PDT, Emilio Cobos Álvarez (:emilio) 		koivisto: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez (:emilio) 2018-06-21 01:41:15 PDT 
Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants.
Comment 1 Emilio Cobos Álvarez (:emilio) 2018-06-21 01:45:55 PDT 
Created attachment 343225 [details]
Patch
Comment 2 Antti Koivisto 2018-06-26 14:08:25 PDT 
r=me
Comment 3 WebKit Commit Bot 2018-06-27 02:28:34 PDT 
Comment on attachment 343225 [details]
Patch

Rejecting attachment 343225 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 343225, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=343225&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=186881&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 343225 from bug 186881.
Fetching: https://bugs.webkit.org/attachment.cgi?id=343225
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/ChangeLog.rej
patching file Source/WebCore/style/StyleTreeResolver.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/8356970
Comment 4 Emilio Cobos Álvarez (:emilio) 2018-06-27 02:34:32 PDT 
Committed r233251: <https://trac.webkit.org/changeset/233251>
Comment 5 Radar WebKit Bug Importer 2018-06-27 02:37:25 PDT 
<rdar://problem/41514587>