Bug 186713 - MediaQuery wastes 335K of vector capacity on theverge.com
Summary: MediaQuery wastes 335K of vector capacity on theverge.com
Status: RESOLVED DUPLICATE of bug 186696
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-15 16:43 PDT by Simon Fraser (smfr)
Modified: 2018-06-16 16:47 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-06-15 16:43:07 PDT 
Wasted capacity: 335584 bytes (used 22816 of 358400 bytes, utilization: 6.37%) - 702 allocations
1   0x107440ce5 WTF::VectorBuffer<WebCore::MediaQueryExpression, 0ul>::VectorBuffer()
2   0x107440cb0 WTF::Vector<WebCore::MediaQueryExpression, 0ul, WTF::CrashOnOverflow, 16ul>::Vector(WTF::Vector<WebCore::MediaQueryExpression, 0ul, WTF::CrashOnOverflow, 16ul>&&)
3   0x107440c7d WTF::Vector<WebCore::MediaQueryExpression, 0ul, WTF::CrashOnOverflow, 16ul>::Vector(WTF::Vector<WebCore::MediaQueryExpression, 0ul, WTF::CrashOnOverflow, 16ul>&&)
4   0x107440c2f WebCore::MediaQuery::MediaQuery(WebCore::MediaQuery&&)
5   0x107440bcd WebCore::MediaQuery::MediaQuery(WebCore::MediaQuery&&)
6   0x107441355 void WTF::Vector<WebCore::MediaQuery, 0ul, WTF::CrashOnOverflow, 16ul>::appendSlowCase<WebCore::MediaQuery>(WebCore::MediaQuery&&)
7   0x1074411f0 void WTF::Vector<WebCore::MediaQuery, 0ul, WTF::CrashOnOverflow, 16ul>::append<WebCore::MediaQuery>(WebCore::MediaQuery&&)
8   0x107428ed5 WTF::Vector<WebCore::MediaQuery, 0ul, WTF::CrashOnOverflow, 16ul>::append(WebCore::MediaQuery&&)

via m_expressions.

Could also re-order members for better packing.
Comment 1 Radar WebKit Bug Importer 2018-06-15 16:43:36 PDT 
<rdar://problem/41176917>
Comment 2 Chris Dumez 2018-06-16 13:34:52 PDT 
Fixed by bug 186696 ?
Comment 3 Simon Fraser (smfr) 2018-06-16 16:47:45 PDT 
Yes, I think so.

*** This bug has been marked as a duplicate of bug 186696 ***