Bug 186624 - svn-apply should handle svn property changes
Summary: svn-apply should handle svn property changes
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-14 10:19 PDT by Roy Reapor
Modified: 2018-09-28 18:11 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roy Reapor 2018-06-14 10:19:47 PDT 
svn-apply should handle svn property changes
Comment 1 Radar WebKit Bug Importer 2018-06-14 10:22:24 PDT 
<rdar://problem/41129393>
Comment 2 Alexey Proskuryakov 2018-06-14 20:41:48 PDT 
I’m pretty sure that it always had. What happened?
Comment 3 Roy Reapor 2018-06-15 09:19:05 PDT 
(In reply to Alexey Proskuryakov from comment #2)
> I’m pretty sure that it always had. What happened?

I found it while investigating why bug 185949 is not Landin.

The SVN pre-commit hook works. But I found that svn-apply doesn't handle property modifications. I also found the comment in svn-apply from 2010. 

$ svn blame svn-apply -v | grep property
 57453 dbates@webkit.org 2010-04-11 12:09:29 -0700 (Sun, 11 Apr 2010) #   Handle property changes.

Correct patches will not be committed correctly if it contains svn property changes.
Comment 4 Aakash Jain 2018-09-28 18:11:51 PDT 
> $ svn blame svn-apply -v | grep property
>  57453 dbates@webkit.org 2010-04-11 12:09:29 -0700 (Sun, 11 Apr 2010) #  
> Handle property changes.
Just for future reference, here is svn-apply code mentioning about missing feature to "handle property changes":
https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/svn-apply#L52