Bug 186586 - [Mail] Use the Mail Viewer height as the base for resolving vertical viewport units
Summary: [Mail] Use the Mail Viewer height as the base for resolving vertical viewport...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-12 21:24 PDT by zalan
Modified: 2018-06-13 16:02 PDT (History)
4 users (show)

See Also:


Attachments
Horizontal-only (8.82 KB, patch)
2018-06-12 22:02 PDT, zalan
no flags Details | Formatted Diff | Diff
Horizontal and vertical (6.98 KB, patch)
2018-06-12 22:04 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-sierra (3.19 MB, application/zip)
2018-06-12 23:43 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.22 MB, application/zip)
2018-06-12 23:51 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews206 for win-future (12.74 MB, application/zip)
2018-06-13 16:01 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-06-12 21:24:07 PDT
ssia
Comment 1 zalan 2018-06-12 21:27:57 PDT
bug 186585 tracks the horizontal viewport unit resolving for autosized content, but we might want to extend this functionality to the vertical viewport units as well.
Comment 2 zalan 2018-06-12 22:02:22 PDT
Created attachment 342629 [details]
Horizontal-only
Comment 3 zalan 2018-06-12 22:04:05 PDT
Created attachment 342630 [details]
Horizontal and vertical

We should also consider overriding the vh as well (for that the enableAutoSize() needs the viewer height too)
Comment 4 EWS Watchlist 2018-06-12 23:43:54 PDT
Comment on attachment 342629 [details]
Horizontal-only

Attachment 342629 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/8157585

New failing tests:
fast/dynamic/noninlinebadness.html
fast/dynamic/outerHTML-img.html
fast/dynamic/outerHTML-doc.html
js/dom/JSON-stringify.html
Comment 5 EWS Watchlist 2018-06-12 23:43:55 PDT
Created attachment 342638 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-06-12 23:51:25 PDT
Comment on attachment 342629 [details]
Horizontal-only

Attachment 342629 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/8157581

New failing tests:
fast/dynamic/mail-autosize-viewport-unit.html
Comment 7 EWS Watchlist 2018-06-12 23:51:26 PDT
Created attachment 342640 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 8 zalan 2018-06-13 08:07:26 PDT
(In reply to Build Bot from comment #4)
> Comment on attachment 342629 [details]
> Horizontal-only
> 
> Attachment 342629 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/8157585
> 
> New failing tests:
> fast/dynamic/noninlinebadness.html
> fast/dynamic/outerHTML-img.html
> fast/dynamic/outerHTML-doc.html
> js/dom/JSON-stringify.html
It looks like we leak the autosize state to subsequent tests.
Comment 9 zalan 2018-06-13 08:46:23 PDT
(In reply to Build Bot from comment #6)
> Comment on attachment 342629 [details]
> Horizontal-only
> 
> Attachment 342629 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/8157581
> 
> New failing tests:
> fast/dynamic/mail-autosize-viewport-unit.html
We don't autosize in iOS?
Comment 10 zalan 2018-06-13 09:06:28 PDT
(In reply to zalan from comment #9)
> (In reply to Build Bot from comment #6)
> > Comment on attachment 342629 [details]
> > Horizontal-only
> > 
> > Attachment 342629 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> > Output: http://webkit-queues.webkit.org/results/8157581
> > 
> > New failing tests:
> > fast/dynamic/mail-autosize-viewport-unit.html
> We don't autosize in iOS?
Wenson and I had a quick chat about this and we concluded that the viewport configuration probably interferes with autosizing on iOS. I don't actually need to test this on iOS. Will just skip it.
Comment 11 EWS Watchlist 2018-06-13 16:01:34 PDT
Comment on attachment 342629 [details]
Horizontal-only

Attachment 342629 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8168748

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
Comment 12 EWS Watchlist 2018-06-13 16:01:46 PDT
Created attachment 342702 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit