Bug 186583 - CFGSimplificationPhase should de-dupe jettisonedBlocks
Summary: CFGSimplificationPhase should de-dupe jettisonedBlocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-12 19:12 PDT by Saam Barati
Modified: 2018-06-14 09:09 PDT (History)
15 users (show)

See Also:

Attachments
patch (1.92 KB, patch)
2018-06-12 19:20 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-06-12 19:12:33 PDT 
Otherwise, we may crash in removing a predecessor, since predecessor list is now also deduplicated.
Comment 1 Saam Barati 2018-06-12 19:13:00 PDT 
This should fix the crash on this test:
js/dom/JSON-stringify.html

introduced by https://trac.webkit.org/changeset/232741/webkit
Comment 2 Saam Barati 2018-06-12 19:20:59 PDT 
Created attachment 342622 [details]
patch

I'm in the middle of building, so I still need to test this, but I'm pretty sure it's the correct fix.
Comment 3 Saam Barati 2018-06-12 21:23:39 PDT 
Comment on attachment 342622 [details]
patch

I've confirmed this fixes the crash.
Comment 4 Robin Morisset 2018-06-13 03:40:54 PDT 
LGTM, but I'm not an official reviewer.
Comment 5 Ryan Haddad 2018-06-13 11:36:56 PDT 
Pinging reviewers. We need the fix ASAP as this is affecting EWS.
Comment 6 WebKit Commit Bot 2018-06-13 12:04:16 PDT 
Comment on attachment 342622 [details]
patch

Clearing flags on attachment: 342622

Committed r232800: <https://trac.webkit.org/changeset/232800>
Comment 7 WebKit Commit Bot 2018-06-13 12:04:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-06-13 12:29:29 PDT 
<rdar://problem/41097203>
Comment 9 Yusuke Suzuki 2018-06-14 01:01:08 PDT 
I think ARES-6 is still crashing.
https://arewefastyet.com/#machine=29&view=breakdown&suite=ares6
Comment 10 Saam Barati 2018-06-14 08:56:55 PDT 
(In reply to Yusuke Suzuki from comment #9)
> I think ARES-6 is still crashing.
> https://arewefastyet.com/#machine=29&view=breakdown&suite=ares6

Michael is working on a fix
Comment 11 Yusuke Suzuki 2018-06-14 09:09:27 PDT 
(In reply to Saam Barati from comment #10)
> (In reply to Yusuke Suzuki from comment #9)
> > I think ARES-6 is still crashing.
> > https://arewefastyet.com/#machine=29&view=breakdown&suite=ares6
> 
> Michael is working on a fix

Nice!