Bug 186548 - Experimental Features "CSS Spring Animations" and "Link Preload" should not be active for production builds
Summary: Experimental Features "CSS Spring Animations" and "Link Preload" should not b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-11 16:41 PDT by Brent Fulgham
Modified: 2018-06-12 13:15 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2018-06-11 16:46 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (8.55 MB, application/zip)
2018-06-11 18:50 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews205 for win-future (12.80 MB, application/zip)
2018-06-12 01:05 PDT, EWS Watchlist 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-06-11 16:41:57 PDT 
The relevant engineers for these two features tell me that they should NOT be enabled by default for production builds:

CSS Spring Animations
Link Preload
Comment 1 Brent Fulgham 2018-06-11 16:43:54 PDT 
<rdar://problem/41023774>
Comment 2 Brent Fulgham 2018-06-11 16:46:36 PDT 
Created attachment 342485 [details]
Patch
Comment 3 EWS Watchlist 2018-06-11 18:50:29 PDT 
Comment on attachment 342485 [details]
Patch

Attachment 342485 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/8139581

New failing tests:
http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html
Comment 4 EWS Watchlist 2018-06-11 18:50:30 PDT 
Created attachment 342498 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 5 EWS Watchlist 2018-06-12 01:05:43 PDT 
Comment on attachment 342485 [details]
Patch

Attachment 342485 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8143848

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 6 EWS Watchlist 2018-06-12 01:05:54 PDT 
Created attachment 342520 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 Brent Fulgham 2018-06-12 12:25:58 PDT 
Those test failures were not related to this patch.
Comment 8 Brent Fulgham 2018-06-12 12:48:35 PDT 
Comment on attachment 342485 [details]
Patch

These test failures can't be related, since the EWS build with these changes is identical to the EWS sources without the changes. Only a Production build would see a difference.
Comment 9 WebKit Commit Bot 2018-06-12 13:15:36 PDT 
Comment on attachment 342485 [details]
Patch

Clearing flags on attachment: 342485

Committed r232771: <https://trac.webkit.org/changeset/232771>
Comment 10 WebKit Commit Bot 2018-06-12 13:15:37 PDT 
All reviewed patches have been landed.  Closing bug.