Bug 186541 - Unpainted area while scrolling in Reader is white
Summary: Unpainted area while scrolling in Reader is white
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-11 14:53 PDT by Tim Horton
Modified: 2018-08-01 00:59 PDT (History)
8 users (show)

See Also:

Attachments
Patch (14.60 KB, patch)
2018-06-11 14:54 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (4.17 MB, application/zip)
2018-06-11 15:45 PDT, EWS Watchlist 		no flags Details
Patch (16.60 KB, patch)
2018-06-12 00:01 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.80 MB, application/zip)
2018-06-12 06:49 PDT, EWS Watchlist 		no flags Details
Patch (19.56 KB, patch)
2018-06-12 12:24 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-06-11 14:53:26 PDT 
Unpainted area while scrolling in Reader is white
Comment 1 Tim Horton 2018-06-11 14:54:26 PDT 
Created attachment 342466 [details]
Patch
Comment 2 Tim Horton 2018-06-11 14:54:37 PDT 
<rdar://problem/40471363>
Comment 3 EWS Watchlist 2018-06-11 15:45:48 PDT 
Comment on attachment 342466 [details]
Patch

Attachment 342466 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/8136386

New failing tests:
tiled-drawing/fixed-layout-size-fixed-attachment-cover.html
tiled-drawing/background-transparency-toggle.html
tiled-drawing/fixed-layout-size-fixed-attachment-local.html
Comment 4 EWS Watchlist 2018-06-11 15:45:49 PDT 
Created attachment 342473 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 Tim Horton 2018-06-12 00:01:48 PDT 
Created attachment 342518 [details]
Patch
Comment 6 EWS Watchlist 2018-06-12 06:49:36 PDT 
Comment on attachment 342518 [details]
Patch

Attachment 342518 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8145981

New failing tests:
http/tests/security/contentSecurityPolicy/video-with-http-url-allowed-by-csp-media-src-star.html
Comment 7 EWS Watchlist 2018-06-12 06:49:47 PDT 
Created attachment 342530 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 8 Tim Horton 2018-06-12 12:24:38 PDT 
Created attachment 342577 [details]
Patch
Comment 9 WebKit Commit Bot 2018-06-19 16:06:16 PDT 
Comment on attachment 342577 [details]
Patch

Clearing flags on attachment: 342577

Committed r232991: <https://trac.webkit.org/changeset/232991>
Comment 10 WebKit Commit Bot 2018-06-19 16:06:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Simon Fraser (smfr) 2018-07-31 18:27:44 PDT 
Comment on attachment 342577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342577&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3148
> +        if (!m_layerForOverhangAreas)
> +            return;

Wait what? You're skipping the setRootLayerConfigurationNeedsUpdate() stuff below.
Comment 12 Tim Horton 2018-08-01 00:59:47 PDT 
(In reply to Simon Fraser (smfr) from comment #11)
> Comment on attachment 342577 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=342577&action=review
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:3148
> > +        if (!m_layerForOverhangAreas)
> > +            return;
> 
> Wait what? You're skipping the setRootLayerConfigurationNeedsUpdate() stuff
> below.

Err, yeah, that needs to only bail from the stuff inside that block