Bug 186498 - [Web Animations] Make WPT test at interfaces/DocumentTimeline/constructor.html pass reliably
Summary: [Web Animations] Make WPT test at interfaces/DocumentTimeline/constructor.htm...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-11 04:38 PDT by Antoine Quint
Modified: 2018-07-09 16:53 PDT (History)
3 users (show)

See Also:

Attachments
Patch (19.88 KB, patch)
2018-07-09 13:56 PDT, Antoine Quint 		dino: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.90 MB, application/zip)
2018-07-09 15:33 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-06-11 04:38:48 PDT 
The WPT test at imported/w3c/web-platform-tests/web-animations/interfaces/DocumentTimeline/constructor.html is failing reliably, flaky or timing out.
Comment 1 Radar WebKit Bug Importer 2018-06-11 04:38:59 PDT 
<rdar://problem/41000205>
Comment 2 Antoine Quint 2018-07-09 13:56:16 PDT 
Created attachment 344610 [details]
Patch
Comment 3 Dean Jackson 2018-07-09 14:15:16 PDT 
Comment on attachment 344610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344610&action=review

> Source/WebCore/animation/DocumentTimeline.idl:29
> +    ConstructorCallWith=Document,

How come this wasn't needed before? How did you create a DocumentTimeline?
Comment 4 Antoine Quint 2018-07-09 14:54:34 PDT 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 344610 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344610&action=review
> 
> > Source/WebCore/animation/DocumentTimeline.idl:29
> > +    ConstructorCallWith=Document,
> 
> How come this wasn't needed before? How did you create a DocumentTimeline?

You didn't, the Document would create one for you and you'd access it via `document.timeline`.
Comment 5 EWS Watchlist 2018-07-09 15:33:16 PDT 
Comment on attachment 344610 [details]
Patch

Attachment 344610 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8485968

New failing tests:
http/tests/security/contentSecurityPolicy/video-with-http-url-allowed-by-csp-media-src-star.html
http/tests/preload/onload_event.html
Comment 6 EWS Watchlist 2018-07-09 15:33:27 PDT 
Created attachment 344631 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 Antoine Quint 2018-07-09 16:53:02 PDT 
Committed r233667: <https://trac.webkit.org/changeset/233667>