Bug 186335 - Add Accept-Encoding: identity to Range requests
Summary: Add Accept-Encoding: identity to Range requests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-05 20:19 PDT by Jake Archibald
Modified: 2018-06-06 21:03 PDT (History)
10 users (show)

See Also:

Attachments
Patch (34.70 KB, patch)
2018-06-06 10:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (34.77 KB, patch)
2018-06-06 20:23 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jake Archibald 2018-06-05 20:19:21 PDT 
Spec change: https://github.com/whatwg/fetch/pull/751
Tests: https://github.com/web-platform-tests/wpt/pull/11291

Turns out a significant number of servers ignore Range headers unless "Accept-Encoding: identity" is set. This spec change applies that header to all requests with a Range header.

Safari already does this for media requests, although the header is applied before the service worker, when it should be afterwards.

Related issues:
https://bugs.webkit.org/show_bug.cgi?id=186050
https://bugs.webkit.org/show_bug.cgi?id=184447
Comment 1 Radar WebKit Bug Importer 2018-06-05 21:58:26 PDT 
<rdar://problem/40837190>
Comment 2 youenn fablet 2018-06-06 10:15:51 PDT 
Created attachment 342056 [details]
Patch
Comment 3 Eric Carlson 2018-06-06 11:44:53 PDT 
Comment on attachment 342056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342056&action=review

> Source/WebCore/loader/cache/CachedResourceRequest.cpp:214
> +    // FIXME: We should ask the media engine to not set this header.

Please file a Radar and include the number here.
Comment 4 youenn fablet 2018-06-06 20:23:00 PDT 
Created attachment 342113 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-06-06 21:03:37 PDT 
Comment on attachment 342113 [details]
Patch for landing

Clearing flags on attachment: 342113

Committed r232571: <https://trac.webkit.org/changeset/232571>
Comment 6 WebKit Commit Bot 2018-06-06 21:03:39 PDT 
All reviewed patches have been landed.  Closing bug.