Bug 186212 - Move tests in LayoutTests/editing to appropriate subdirectories
Summary: Move tests in LayoutTests/editing to appropriate subdirectories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-01 16:57 PDT by Ryosuke Niwa
Modified: 2018-06-04 17:32 PDT (History)
5 users (show)

See Also:

Attachments
Moves the tests (17.72 KB, patch)
2018-06-01 17:00 PDT, Ryosuke Niwa 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-06-01 16:57:39 PDT 
Move tests in LayoutTests/editing to its subdirectories.
Comment 1 Ryosuke Niwa 2018-06-01 17:00:06 PDT 
Created attachment 341808 [details]
Moves the tests
Comment 2 Wenson Hsieh 2018-06-01 17:02:29 PDT 
Comment on attachment 341808 [details]
Moves the tests

rs=me
Comment 3 Ryosuke Niwa 2018-06-01 17:04:45 PDT 
Committed r232430: <https://trac.webkit.org/changeset/232430>
Comment 4 Radar WebKit Bug Importer 2018-06-01 17:46:59 PDT 
<rdar://problem/40740845>
Comment 5 Dawei Fenton (:realdawei) 2018-06-04 15:22:42 PDT 
Looks like this caused a regression in the following test:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fselection%2Fsimple-line-layout-caret-is-gone.html

Regressions: Unexpected text-only failures (1)
  editing/selection/simple-line-layout-caret-is-gone.html [ Failure ]
Comment 6 Ryosuke Niwa 2018-06-04 16:16:08 PDT 
(In reply to David Fenton from comment #5)
> Looks like this caused a regression in the following test:
> 
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=editing%2Fselection%2Fsimple-line-layout-caret-
> is-gone.html
> 
> Regressions: Unexpected text-only failures (1)
>   editing/selection/simple-line-layout-caret-is-gone.html [ Failure ]

Looks like I forgot to move the platform specific results in that revision.
Comment 7 Ryosuke Niwa 2018-06-04 17:32:47 PDT 
Fixed it in https://trac.webkit.org/changeset/232488.