Bug 186169 - PutStructure AI rule needs to call didFoldClobberStructures when the incoming value's structure set is clear
Summary: PutStructure AI rule needs to call didFoldClobberStructures when the incoming...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-31 17:12 PDT by Saam Barati
Modified: 2018-05-31 20:07 PDT (History)
13 users (show)

See Also:


Attachments
patch (1.86 KB, patch)
2018-05-31 17:16 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-05-31 17:12:27 PDT
Otherwise, AI and Clobberize will disagree. It's somewhat inconsequential since we're going to exit, but for the sake of validation, we've folded.
Comment 1 Saam Barati 2018-05-31 17:16:21 PDT
Created attachment 341713 [details]
patch
Comment 2 Mark Lam 2018-05-31 17:23:56 PDT
Comment on attachment 341713 [details]
patch

LGTM
Comment 3 WebKit Commit Bot 2018-05-31 20:06:31 PDT
Comment on attachment 341713 [details]
patch

Clearing flags on attachment: 341713

Committed r232384: <https://trac.webkit.org/changeset/232384>
Comment 4 WebKit Commit Bot 2018-05-31 20:06:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-05-31 20:07:49 PDT
<rdar://problem/40709413>