WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
183374
LayoutTests/http/tests/misc/window-dot-stop.html fails with async policy delegate
https://bugs.webkit.org/show_bug.cgi?id=183374
Summary
LayoutTests/http/tests/misc/window-dot-stop.html fails with async policy dele...
Danyao Wang
Reported
2018-03-06 09:41:53 PST
This test now fails because with async decide policy, the iframe navigation is canceled before it gets to willSendRequest stage. window.stop is still working as intended.
Attachments
Patch
(3.14 KB, patch)
2018-03-06 10:29 PST
,
Danyao Wang
no flags
Details
Formatted Diff
Diff
Fixed typo. Patch for review
(3.15 KB, patch)
2018-03-06 10:33 PST
,
Danyao Wang
cdumez
: review-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Danyao Wang
Comment 1
2018-03-06 10:29:00 PST
Created
attachment 335112
[details]
Patch
Danyao Wang
Comment 2
2018-03-06 10:33:15 PST
Created
attachment 335113
[details]
Fixed typo. Patch for review
Chris Dumez
Comment 3
2018-03-06 10:43:31 PST
Comment on
attachment 335113
[details]
Fixed typo. Patch for review You would also need to fix the existing test. Otherwise, this does not help us enable async delegates by default. In this case though, since there is no code change, I am not convinced it is worth landing any new test. We can merely rebaseline LayoutTests/http/tests/misc/window-dot-stop.html when we enable async delegates by default.
Danyao Wang
Comment 4
2018-03-06 11:24:32 PST
OK that sounds reasonable. I think the failure message I added to the onload events make the test slightly more clear, but this seems minor and I'm OK just rebaseline later.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug