RESOLVED FIXED 172397
Layout Test animations/needs-layout.html is a flaky Image Failure.
https://bugs.webkit.org/show_bug.cgi?id=172397
Summary Layout Test animations/needs-layout.html is a flaky Image Failure.
Matt Lewis
Reported 2017-05-19 16:00:39 PDT
The test animations/needs-layout.html is a flaky image failure on macOS Sierra. It has failed on WK1 release and WK2 Debug. The test seems to have been flaky from when it was added. https://trac.webkit.org/changeset/217075/webkit https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=animations%2Fneeds-layout.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/1103 https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r217140%20(1103)/results.html I was able to reproduce the failure in Sierra debug with: run-webkit-tests animations/needs-layout.html --debug --no-retry-failure --iterations=50 -f
Attachments
Patch (11.28 KB, patch)
2018-04-16 15:47 PDT, Antoine Quint
dino: review+
ews-watchlist: commit-queue-
Archive of layout-test-results from ews116 for mac-sierra (2.99 MB, application/zip)
2018-04-16 17:22 PDT, EWS Watchlist
no flags
Alexey Proskuryakov
Comment 1 2017-05-24 16:46:01 PDT
This is a new test, just added in bug 172300. Dean, can you take a look please?
Matt Lewis
Comment 2 2017-07-05 16:45:06 PDT
Matt Lewis
Comment 4 2017-10-31 12:55:17 PDT
Ryan Haddad
Comment 5 2018-04-13 16:52:43 PDT
This test is now flaky on release, too.
Antoine Quint
Comment 6 2018-04-16 15:47:34 PDT
EWS Watchlist
Comment 7 2018-04-16 17:22:58 PDT
Comment on attachment 338050 [details] Patch Attachment 338050 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7336578 New failing tests: legacy-animation-engine/css3/masking/clip-path-animation.html
EWS Watchlist
Comment 8 2018-04-16 17:22:59 PDT
Created attachment 338064 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Antoine Quint
Comment 9 2018-04-17 00:31:44 PDT
(In reply to Build Bot from comment #7) > Comment on attachment 338050 [details] > Patch > > Attachment 338050 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/7336578 > > New failing tests: > legacy-animation-engine/css3/masking/clip-path-animation.html This crash should not be related to this patch which only affects the code path used for the new animation engine. This test uses the legacy animation engine and the ASSERT reached in FrameView is conditioned to only run on the legacy code path, so we are indeed not using the new one.
Antoine Quint
Comment 10 2018-04-17 00:34:07 PDT
Antoine Quint
Comment 11 2018-04-17 00:34:07 PDT
*** Bug 184638 has been marked as a duplicate of this bug. ***
Radar WebKit Bug Importer
Comment 12 2018-04-17 00:35:19 PDT
Note You need to log in before you can comment on or make changes to this bug.