NEW165265
Allow clients of _WKFullscreenDelegate to specify a window to use for fullscreen 
https://bugs.webkit.org/show_bug.cgi?id=165265
Summary Allow clients of _WKFullscreenDelegate to specify a window to use for fullscreen
Jer Noble
Reported 2016-12-01 12:33:02 PST
Allow clients of _WKFullscreenDelegate to specify a window to use for fullscreen
Attachments
Patch (25.63 KB, patch)
2016-12-01 12:47 PST, Jer Noble 		beidson: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-12-01 12:47:16 PST
Created attachment 295880 [details] Patch
Sam Weinig
Comment 2 2016-12-01 20:27:34 PST
Comment on attachment 295880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295880&action=review > Source/WebKit2/UIProcess/API/Cocoa/_WKFullscreenWindow.h:36 > + > +#if WK_API_ENABLED > + > +@protocol _WKFullscreenWindow <NSObject> > +@property (readonly, nonnull) NSView *parentViewForWebView; > +@end > + > +#endif I think this needs some guards (#if !TARGET_OS_IPHONE) since these types are Mac only. Will we want a similar concept on iOS?
Jer Noble
Comment 3 2016-12-02 09:06:00 PST
Comment on attachment 295880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295880&action=review >> Source/WebKit2/UIProcess/API/Cocoa/_WKFullscreenWindow.h:36 >> +#endif > > I think this needs some guards (#if !TARGET_OS_IPHONE) since these types are Mac only. Will we want a similar concept on iOS? Sure, and we very well may if clients there will want to provide their own fullscreen window. We could do something like: #if TARGET_OS_IPHONE typedef UIView ViewClass; #else typedef NSView ViewClass; #endif ... @property (readonly, non null) ViewClass *parentViewForWebView;
Brady Eidson
Comment 4 2018-02-14 10:36:11 PST
Comment on attachment 295880 [details] Patch Patches that have been up for review since 2016 are almost certainly too stale to be relevant to trunk in their current form. If this patch is still important please rebase it and post it for review again.
Frédéric Wang Nélar
Comment 5 2026-10-29 23:54:57 PDT
Jer Noble: Is this still desired?
Note You need to log in before you can comment on or make changes to this bug.