RESOLVED FIXED 159049
Enable window.open() for existing versions of Secret Society (compatibility) 
https://bugs.webkit.org/show_bug.cgi?id=159049
Summary Enable window.open() for existing versions of Secret Society (compatibility)
John Wilander
Reported 2016-06-22 17:52:29 PDT
The Secret Society Hidden Mystery app has a broken version check treating iOS 10 as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap handler. We should allow the existing versions of the app to do this to not break them.
Attachments
Patch (7.99 KB, patch)
2016-06-22 18:29 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (7.64 KB, patch)
2016-06-23 08:59 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (7.51 KB, patch)
2016-06-23 09:06 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
John Wilander
Comment 1 2016-06-22 17:54:16 PDT
rdar://problem/26528349
John Wilander
Comment 2 2016-06-22 18:29:47 PDT
Created attachment 281893 [details] Patch
Andy Estes
Comment 3 2016-06-22 18:38:11 PDT
Comment on attachment 281893 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281893&action=review > Source/WTF/wtf/spi/darwin/dyldSPI.h:40 > +#define DYLD_IOS_VERSION_3_0 0x00030000 > +#define DYLD_IOS_VERSION_4_2 0x00040200 > +#define DYLD_IOS_VERSION_5_0 0x00050000 > +#define DYLD_IOS_VERSION_6_0 0x00060000 > +#define DYLD_IOS_VERSION_7_0 0x00070000 > +#define DYLD_IOS_VERSION_9_0 0x00090000 > +#define DYLD_IOS_VERSION_10_0 0x000A0000 We try to avoid lining things up on column boundaries like this. The problem with doing this is that we'd no longer get useful blame information for lines 34-39. > Source/WebCore/page/DOMWindow.cpp:357 > - > + Please remove this. > Source/WebCore/page/DOMWindow.cpp:366 > + And this.
John Wilander
Comment 4 2016-06-23 08:59:13 PDT
Created attachment 281909 [details] Patch
John Wilander
Comment 5 2016-06-23 09:06:06 PDT
Created attachment 281910 [details] Patch
John Wilander
Comment 6 2016-06-23 09:07:47 PDT
(In reply to comment #3) > Comment on attachment 281893 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281893&action=review > > > Source/WTF/wtf/spi/darwin/dyldSPI.h:40 > > +#define DYLD_IOS_VERSION_3_0 0x00030000 > > +#define DYLD_IOS_VERSION_4_2 0x00040200 > > +#define DYLD_IOS_VERSION_5_0 0x00050000 > > +#define DYLD_IOS_VERSION_6_0 0x00060000 > > +#define DYLD_IOS_VERSION_7_0 0x00070000 > > +#define DYLD_IOS_VERSION_9_0 0x00090000 > > +#define DYLD_IOS_VERSION_10_0 0x000A0000 > > We try to avoid lining things up on column boundaries like this. The problem > with doing this is that we'd no longer get useful blame information for > lines 34-39. I recall you telling me this previously. :) Fixed. > > > Source/WebCore/page/DOMWindow.cpp:357 > > - > > + > > Please remove this. > > > Source/WebCore/page/DOMWindow.cpp:366 > > + > > And this. Fixed them both and another stray tab. Thanks!
WebKit Commit Bot
Comment 7 2016-06-23 09:35:30 PDT
Comment on attachment 281910 [details] Patch Clearing flags on attachment: 281910 Committed r202380: <http://trac.webkit.org/changeset/202380>
WebKit Commit Bot
Comment 8 2016-06-23 09:35:35 PDT
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 9 2016-06-23 15:53:52 PDT
(In reply to comment #7) > Comment on attachment 281910 [details] > Patch > > Clearing flags on attachment: 281910 > > Committed r202380: <http://trac.webkit.org/changeset/202380> Follow-up build fix for internal iOS 9.x SDK builds: Committed r202400: <http://trac.webkit.org/changeset/r202400>
John Wilander
Comment 10 2016-06-23 15:56:05 PDT
Thanks, Dave!
Alexey Proskuryakov
Comment 11 2016-06-23 19:46:06 PDT
> Follow-up build fix for internal iOS 9.x SDK builds: > > Committed r202400: <http://trac.webkit.org/changeset/r202400> ChangeLog for the build fix says "Define DYLD_IOS_VERSION_10_0 when building on internal SDKs older than iOS 10" - but the patch implemented something different. It defined the macro when targeting a pre-iOS 10 SDK. To check for SDK version, use MAX_ALLOWED, not MIN_REQUIRED.
Darin Adler
Comment 12 2017-01-21 09:35:19 PST
I believe we should remove the setting allowWindowOpenWithoutUserGesture because it is a duplicate of the already-existing setting javaScriptCanOpenWindowsAutomatically.
Darin Adler
Comment 13 2017-01-21 13:56:33 PST
Maybe Joe wants to tackle this as part of his cleanup?
Note You need to log in before you can comment on or make changes to this bug.