WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
157225
Rename getAssignedNodes to assignedNodes and support flattened option
https://bugs.webkit.org/show_bug.cgi?id=157225
Summary
Rename getAssignedNodes to assignedNodes and support flattened option
Ryosuke Niwa
Reported
2016-04-29 20:00:05 PDT
Update HTMLSlotElement.prototype.getAssignedNodes to match the latest spec.
Attachments
Patch
(27.84 KB, patch)
2016-04-29 20:24 PDT
,
Ryosuke Niwa
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2016-04-29 20:24:28 PDT
Created
attachment 277787
[details]
Patch
Antti Koivisto
Comment 2
2016-04-29 21:01:19 PDT
Comment on
attachment 277787
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=277787&action=review
> Source/WebCore/html/HTMLSlotElement.cpp:110 > + } else > + nodes.append(node);
I usually use continue rather than dangling else like this.
Ryosuke Niwa
Comment 3
2016-04-29 21:18:27 PDT
Committed
r200285
: <
http://trac.webkit.org/changeset/200285
>
Radar WebKit Bug Importer
Comment 4
2016-04-29 23:07:50 PDT
<
rdar://problem/26022326
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug