RESOLVED FIXED148243
Web Inspector: Add flex alignment section to Visual sidebar 
https://bugs.webkit.org/show_bug.cgi?id=148243
Summary Web Inspector: Add flex alignment section to Visual sidebar
Devin Rousso
Reported 2015-08-20 14:04:51 PDT
Currently, the layout properties for flex box have visual editors, but the alignment (align, justify, etc.) properties do not.
Attachments
Patch (5.99 KB, patch)
2015-08-20 16:30 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-20 14:05:54 PDT
<rdar://problem/22367976>
Devin Rousso
Comment 2 2015-08-20 16:30:01 PDT
Created attachment 259517 [details] Patch
Timothy Hatcher
Comment 3 2015-08-20 17:12:32 PDT
Comment on attachment 259517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review > Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590 > + advanced: advancedAlignmentKeywords.concat(["Space Evenly"]) Really advanced? I could see this being in the basic list.
Devin Rousso
Comment 4 2015-08-20 17:13:30 PDT
Comment on attachment 259517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review >> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590 >> + advanced: advancedAlignmentKeywords.concat(["Space Evenly"]) > > Really advanced? I could see this being in the basic list. I put it in the advanced list because it is a CSS Grid layout keyword and doesn't work for Flexbox. Since Grid is much less supported than Flexbox, I don't want the users getting confused.
Timothy Hatcher
Comment 5 2015-08-20 17:14:16 PDT
Comment on attachment 259517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review >>> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590 >>> + advanced: advancedAlignmentKeywords.concat(["Space Evenly"]) >> >> Really advanced? I could see this being in the basic list. > > I put it in the advanced list because it is a CSS Grid layout keyword and doesn't work for Flexbox. Since Grid is much less supported than Flexbox, I don't want the users getting confused. Makes sense.
WebKit Commit Bot
Comment 6 2015-08-20 18:42:31 PDT
Comment on attachment 259517 [details] Patch Clearing flags on attachment: 259517 Committed r188733: <http://trac.webkit.org/changeset/188733>
WebKit Commit Bot
Comment 7 2015-08-20 18:42:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.