RESOLVED FIXED 140918
Implement ES6 class syntax without inheritance support 
https://bugs.webkit.org/show_bug.cgi?id=140918
Summary Implement ES6 class syntax without inheritance support
Ryosuke Niwa
Reported 2015-01-26 19:10:29 PST
Let us first implement the ES6 class syntax without "extends" or "super" support.
Attachments
Implements the feature (40.48 KB, patch)
2015-01-26 20:40 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-mavericks (627.80 KB, application/zip)
2015-01-26 21:03 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (811.96 KB, application/zip)
2015-01-26 21:14 PST, Build Bot 		no flags
Details
Fixed the tests (39.44 KB, patch)
2015-01-26 21:53 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-mavericks (243.27 KB, application/zip)
2015-01-26 22:06 PST, Build Bot 		no flags
Details
Second attempt to fix tests (40.54 KB, patch)
2015-01-26 22:07 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Don't leak identifiers (39.46 KB, patch)
2015-01-27 16:58 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-01-26 20:40:56 PST
Created attachment 245406 [details] Implements the feature
Build Bot
Comment 2 2015-01-26 21:03:32 PST
Comment on attachment 245406 [details] Implements the feature Attachment 245406 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5323382946004992 New failing tests: webgl/1.0.2/conformance/glsl/functions/glsl-function-reflect.html webgl/1.0.2/conformance/glsl/functions/glsl-function-normalize.html webgl/1.0.2/conformance/glsl/functions/glsl-function-faceforward.html js/dom/JSON-stringify.html
Build Bot
Comment 3 2015-01-26 21:03:37 PST
Created attachment 245410 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 4 2015-01-26 21:14:35 PST
Comment on attachment 245406 [details] Implements the feature Attachment 245406 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5048201170124800 New failing tests: webgl/1.0.2/conformance/glsl/functions/glsl-function-reflect.html webgl/1.0.2/conformance/glsl/functions/glsl-function-normalize.html webgl/1.0.2/conformance/glsl/functions/glsl-function-faceforward.html js/dom/JSON-stringify.html
Build Bot
Comment 5 2015-01-26 21:14:38 PST
Created attachment 245413 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Ryosuke Niwa
Comment 6 2015-01-26 21:53:02 PST
Created attachment 245417 [details] Fixed the tests
Build Bot
Comment 7 2015-01-26 22:06:50 PST
Comment on attachment 245417 [details] Fixed the tests Attachment 245417 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5798757442519040 Number of test failures exceeded the failure limit.
Build Bot
Comment 8 2015-01-26 22:06:53 PST
Created attachment 245421 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Ryosuke Niwa
Comment 9 2015-01-26 22:07:04 PST
Created attachment 245422 [details] Second attempt to fix tests
Geoffrey Garen
Comment 10 2015-01-27 15:02:08 PST
Comment on attachment 245422 [details] Second attempt to fix tests View in context: https://bugs.webkit.org/attachment.cgi?id=245422&action=review Looks mostly OK. > Source/JavaScriptCore/parser/Nodes.h:1625 > + Identifier m_name; This is a memory leak. In the parser, we (usually) don't run destructors. You should arrange to use Identifier& instead, like other AST nodes. It would be nice if you could add a has_trivial_destructor ASSERT somewhere to catch this kind of thing in the future.
Ryosuke Niwa
Comment 11 2015-01-27 16:58:52 PST
Created attachment 245495 [details] Don't leak identifiers
Geoffrey Garen
Comment 12 2015-01-29 12:51:50 PST
Comment on attachment 245495 [details] Don't leak identifiers r=me
WebKit Commit Bot
Comment 13 2015-01-29 14:59:18 PST
Comment on attachment 245495 [details] Don't leak identifiers Clearing flags on attachment: 245495 Committed r179371: <http://trac.webkit.org/changeset/179371>
WebKit Commit Bot
Comment 14 2015-01-29 14:59:25 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 15 2015-01-29 15:53:40 PST
(In reply to comment #13) > Comment on attachment 245495 [details] > Don't leak identifiers > > Clearing flags on attachment: 245495 > > Committed r179371: <http://trac.webkit.org/changeset/179371> The tests fail on the bots, please skip them for jsc-stress-tests too.
Ryosuke Niwa
Comment 16 2015-01-29 16:37:18 PST
(In reply to comment #15) > (In reply to comment #13) > > Comment on attachment 245495 [details] > > Don't leak identifiers > > > > Clearing flags on attachment: 245495 > > > > Committed r179371: <http://trac.webkit.org/changeset/179371> > > The tests fail on the bots, please skip them for jsc-stress-tests too. Oops, sorry about that. Skipped them in https://trac.webkit.org/r179379
Note You need to log in before you can comment on or make changes to this bug.