RESOLVED FIXED 130644
Call linking slow paths should be passed a CallLinkInfo* directly so that you can create a call IC without adding it to any CodeBlocks
https://bugs.webkit.org/show_bug.cgi?id=130644
Summary Call linking slow paths should be passed a CallLinkInfo* directly so that you...
Filip Pizlo
Reported 2014-03-22 13:00:56 PDT
Patch forthcoming.
Attachments
less than half way there (37.69 KB, patch)
2014-03-22 13:01 PDT, Filip Pizlo
no flags
it builds on 64-bit (56.78 KB, patch)
2014-03-22 14:35 PDT, Filip Pizlo
no flags
starting to work on 64-bit x86 (61.30 KB, patch)
2014-03-22 15:45 PDT, Filip Pizlo
no flags
the patch (68.71 KB, patch)
2014-03-22 20:06 PDT, Filip Pizlo
kling: review+
Filip Pizlo
Comment 1 2014-03-22 13:01:43 PDT
Created attachment 227564 [details] less than half way there
Filip Pizlo
Comment 2 2014-03-22 14:35:24 PDT
Created attachment 227574 [details] it builds on 64-bit It even appears to pass testapi, but I'm sure it has many, many bugs.
Filip Pizlo
Comment 3 2014-03-22 15:45:56 PDT
Created attachment 227576 [details] starting to work on 64-bit x86
Filip Pizlo
Comment 4 2014-03-22 20:06:05 PDT
Created attachment 227595 [details] the patch
Andreas Kling
Comment 5 2014-03-22 21:26:19 PDT
Comment on attachment 227595 [details] the patch r=me I'd suggest using "auto" instead of Bag<T>::iterator, since you seem to like short lines. ;)
Filip Pizlo
Comment 6 2014-03-22 21:35:10 PDT
(In reply to comment #5) > (From update of attachment 227595 [details]) > r=me > > I'd suggest using "auto" instead of Bag<T>::iterator, since you seem to like short lines. ;) I did it!
Filip Pizlo
Comment 7 2014-03-22 21:35:34 PDT
Simon Fraser (smfr)
Comment 8 2014-03-23 09:49:54 PDT
This broke the CLOOP build.
Csaba Osztrogonác
Comment 9 2014-03-24 08:30:11 PDT
(In reply to comment #8) > This broke the CLOOP build. new bug report for fixing the build: https://bugs.webkit.org/show_bug.cgi?id=130670
Note You need to log in before you can comment on or make changes to this bug.