WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
124795
[Win] Clean up ColorSpace handling in Windows code
https://bugs.webkit.org/show_bug.cgi?id=124795
Summary
[Win] Clean up ColorSpace handling in Windows code
Brent Fulgham
Reported
2013-11-22 15:20:21 PST
There were some hard-coded DeviceColorSpace calls in the Windows code that should be revised to match all other platforms. This patch properly handles the sRGB color space (both on older Windows installations and current software) so that our existing test suites pass. It also removes some hard-coded ColorSpace values that were introduced while correcting a build failure around four years ago that were never revised to take advantage of the API.
Attachments
Patch
(6.11 KB, patch)
2013-11-22 15:28 PST
,
Brent Fulgham
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2013-11-22 15:28:43 PST
Created
attachment 217720
[details]
Patch
Brent Fulgham
Comment 2
2013-11-22 15:44:37 PST
<
rdar://problem/7387791
>
Tim Horton
Comment 3
2013-11-22 15:55:04 PST
Comment on
attachment 217720
[details]
Patch r+ with the changes discussed on IRC
Brent Fulgham
Comment 4
2013-11-22 16:15:34 PST
Committed
r159720
: <
http://trac.webkit.org/changeset/159720
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug