RESOLVED FIXED 119864
[CSS Shapes] Remove extraneous window.internals calls in layout tests 
https://bugs.webkit.org/show_bug.cgi?id=119864
Summary [CSS Shapes] Remove extraneous window.internals calls in layout tests
Bear Travis
Reported 2013-08-15 14:23:33 PDT
With CSS Shapes enabled by default in nightly builds, we no longer have to explicitly enable CSS Shapes for each test.
Attachments
Initial patch (80.75 KB, patch)
2013-08-15 14:29 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2013-08-15 14:29:13 PDT
Created attachment 208856 [details] Initial patch
Darin Adler
Comment 2 2013-08-15 18:27:11 PDT
Comment on attachment 208856 [details] Initial patch Can we wait on this change until most platforms are shipping this feature by default? What’s the rush?
Bear Travis
Comment 3 2013-08-16 10:29:16 PDT
This patch is just cleanup, as the window.internals.settings.setCSSShapesEnabled calls in these tests are unnecessary. The platforms that expose setCSSShapesEnabled now have shapes enabled by default, and the platforms that don't exclude these test directories. window.internals.settings.setCSSShapesEnabled(true) is basically a no-op. These tests would fail with or without this patch in builds that do not compile with ENABLE_CSS_SHAPES flag set.
Alexandru Chiculita
Comment 4 2013-08-23 10:46:49 PDT
Comment on attachment 208856 [details] Initial patch r=me
WebKit Commit Bot
Comment 5 2013-08-23 11:09:29 PDT
Comment on attachment 208856 [details] Initial patch Clearing flags on attachment: 208856 Committed r154500: <http://trac.webkit.org/changeset/154500>
WebKit Commit Bot
Comment 6 2013-08-23 11:09:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.