RESOLVED DUPLICATE of bug 246065111636
RenderFullScreen should call setNeedsLayoutAndPrefWidthsRecalc on the child (?)
https://bugs.webkit.org/show_bug.cgi?id=111636
Summary RenderFullScreen should call setNeedsLayoutAndPrefWidthsRecalc on the child (?)
Christian Biesinger
Reported 2013-03-06 15:46:30 PST
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderFullScreen.cpp?rev=HEAD#L154 The code here looks like: 154 while ((child = firstChild())) { 155 child->remove(); 156 parent()->addChild(child, this); 157 parent()->setNeedsLayoutAndPrefWidthsRecalc(); 158 } It seems to me like setNeedsLayoutAndPrefWidthsRecalc() should be called on the child (which then would recurse through the parents). hyatt, does that seem plausible? At least, if it is right to call it on the parent, it should be outside the loop. (I don't have a testcase either way, we found this by code inspection)
Attachments
Frédéric Wang Nélar
Comment 1 2026-10-13 01:46:03 PDT
RenderFullScreen was removed in https://commits.webkit.org/255641@main *** This bug has been marked as a duplicate of bug 246065 ***
Note You need to log in before you can comment on or make changes to this bug.