RESOLVED FIXED 102537
Computed grid items' positions shouldn't be using Length 
https://bugs.webkit.org/show_bug.cgi?id=102537
Summary Computed grid items' positions shouldn't be using Length
Julien Chaffraix
Reported 2012-11-16 10:54:30 PST
Currently we convert grid-row and grid-column (resp. grid-row-position / grid-column-position in the latest spec) to Length inside StyleGridItemData: // FIXME: For the moment, we only support a subset of the grammar which correspond to: // 'auto' | <length> // When we add more of the syntax, we will need a dedicated GridPosition class. Length m_gridColumn; Length m_gridRow; (The comment is wrong, the grammar only allows <integer> not <length>) Ojan pointed out in bug 102441 that it's confusing to use Length. The type was meant to be a temporary type to get the ball rolling so and it's probably time to kill this hack.
Attachments
Proposed change: add GridPosition. (19.13 KB, patch)
2012-11-16 11:37 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-11-16 11:37:33 PST
Created attachment 174729 [details] Proposed change: add GridPosition.
Tony Chang
Comment 2 2012-11-16 13:13:52 PST
Comment on attachment 174729 [details] Proposed change: add GridPosition. LGTM
WebKit Review Bot
Comment 3 2012-11-19 08:40:17 PST
Comment on attachment 174729 [details] Proposed change: add GridPosition. Clearing flags on attachment: 174729 Committed r135164: <http://trac.webkit.org/changeset/135164>
WebKit Review Bot
Comment 4 2012-11-19 08:40:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.