RESOLVED FIXED 101913
Remove HTMLInputElement dependency from PickerIndicatorElement 
https://bugs.webkit.org/show_bug.cgi?id=101913
Summary Remove HTMLInputElement dependency from PickerIndicatorElement
Kunihiko Sakamoto
Reported 2012-11-12 02:21:43 PST
Introduce PickerIndicatorOwner interface that replaces the role of hostInput() in PickerIndicatorElement. It makes easier to add interactions between picker indicator and its owner without adding functions to HTMLInputElement.
Attachments
Patch (12.51 KB, patch)
2012-11-12 02:42 PST, Kunihiko Sakamoto 		no flags
DetailsFormatted DiffDiff
Patch 2 (12.07 KB, patch)
2012-11-12 03:16 PST, Kunihiko Sakamoto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kunihiko Sakamoto
Comment 1 2012-11-12 02:42:10 PST
Created attachment 173596 [details] Patch
Kent Tamura
Comment 2 2012-11-12 02:54:08 PST
Comment on attachment 173596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173596&action=review The code looks ok. One comment. > Source/WebCore/html/shadow/PickerIndicatorElement.h:53 > + virtual bool isPickerIndicatorOwnerDisabled() const = 0; > + virtual bool isPickerIndicatorOwnerReadOnly() const = 0; They are called together every time. So we may merge them into one function like isPickerIndicatorOwnerDisabledOrReadOnly(). This pattern is used in FieldOwner in WebCore/html/shadow/DateTimeFieldElement.h.
Kunihiko Sakamoto
Comment 3 2012-11-12 03:16:21 PST
Created attachment 173600 [details] Patch 2
Kunihiko Sakamoto
Comment 4 2012-11-12 03:16:41 PST
Comment on attachment 173596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173596&action=review >> Source/WebCore/html/shadow/PickerIndicatorElement.h:53 >> + virtual bool isPickerIndicatorOwnerReadOnly() const = 0; > > They are called together every time. So we may merge them into one function like isPickerIndicatorOwnerDisabledOrReadOnly(). This pattern is used in FieldOwner in WebCore/html/shadow/DateTimeFieldElement.h. Done.
Kent Tamura
Comment 5 2012-11-12 03:30:18 PST
Comment on attachment 173600 [details] Patch 2 ok, great.
WebKit Review Bot
Comment 6 2012-11-12 04:22:17 PST
Comment on attachment 173600 [details] Patch 2 Clearing flags on attachment: 173600 Committed r134206: <http://trac.webkit.org/changeset/134206>
WebKit Review Bot
Comment 7 2012-11-12 04:22:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.