RESOLVED WONTFIX 100861
[chromium] Enable RESOLUTION_MEDIA_QUERY 
https://bugs.webkit.org/show_bug.cgi?id=100861
Summary [chromium] Enable RESOLUTION_MEDIA_QUERY
Rick Byers
Reported 2012-10-31 07:49:03 PDT
Kenneth recently landed support for 'resolution' media queries and dppx units (bug 99077). I think we should enable it in chromium.
Attachments
Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-10-31 07:52:20 PDT
We'll need ENABLE_CSS_IMAGE_RESOLUTION as well as it depends on that. I do completely concur for Android, but johnme@ has some concerns regarding the units we'd expose.
Rick Byers
Comment 2 2012-10-31 07:57:04 PDT
(In reply to comment #1) > We'll need ENABLE_CSS_IMAGE_RESOLUTION as well as it depends on that. Are you sure? From the code it looked to me like it was perhaps designed to work without it. Anyway I will give it a try sometime soon (just some higher priority things in my queue first). > I do completely concur for Android, but johnme@ has some concerns regarding the units we'd expose. Great, let's discuss any concerns. Tab has been working on the spec, so I hope he's already been made aware of any concerns chromium folks have with it.
Peter Beverloo
Comment 3 2012-10-31 08:04:16 PDT
(In reply to comment #2) > Are you sure? From the code it looked to me like it was perhaps designed to work without it. Anyway I will give it a try sometime soon (just some higher priority things in my queue first). I should read patches more carefully :-). You're right, thanks!
Kenneth Rohde Christiansen
Comment 4 2012-10-31 08:16:33 PDT
Be aware that Chromium needs to stop forwarding the actual device dpi to the screen.vertical|horizontalDPI methods.
John Mellor
Comment 5 2012-10-31 09:44:58 PDT
(In reply to comment #2) > (In reply to comment #1) > > I do completely concur for Android, but johnme@ has some concerns regarding the units we'd expose. > > Great, let's discuss any concerns. Tab has been working on the spec, so I hope he's already been made aware of any concerns chromium folks have with it. I filed bug 100865 about this. (In reply to comment #4) > Be aware that Chromium needs to stop forwarding the actual device dpi to the screen.vertical|horizontalDPI methods. Why do we need to stop this? And what should we do instead?
Kenneth Rohde Christiansen
Comment 6 2012-10-31 10:34:26 PDT
(In reply to comment #5) > (In reply to comment #2) > > (In reply to comment #1) > > > I do completely concur for Android, but johnme@ has some concerns regarding the units we'd expose. > > > > Great, let's discuss any concerns. Tab has been working on the spec, so I hope he's already been made aware of any concerns chromium folks have with it. > > I filed bug 100865 about this. > > (In reply to comment #4) > > Be aware that Chromium needs to stop forwarding the actual device dpi to the screen.vertical|horizontalDPI methods. > > Why do we need to stop this? And what should we do instead? As far as I can tell you are not using it for anything (via that api) and the values are also not exposed to the web content (not declared in the idl). So I don't think you need to do anything instead.
Stephen Chenney
Comment 7 2013-04-09 17:07:32 PDT
Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.
Note You need to log in before you can comment on or make changes to this bug.