Bug 63164
| Summary: | CompositeEditingCommand::splitTreeToNode should split to a position instead. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Annie Sullivan <sullivan> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED LATER | ||
| Severity: | Normal | CC: | ahmad.saleem792, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Annie Sullivan
The method should be renamed splitTree(Position& start, Node*end, enum shouldSplitAncestor).
Looking at the callsites makes it clear why we really should to split to a position:
* Most of them actually split to a position.containerNode() or position.deprecatedNode() already
* InsertListCommand::doApply has a lot of logic for picking the node to split to which would be greatly simplified by splitting to a position
* ReplaceSelectionCommand::insertAsListItems has to do some extra splitting of text nodes that would happen automatically in splitNodeToPosition
* InsertParagraphSeparatorCommand::doApply() recently regressed because sometimes it would pick the wrong node to split to from the position.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
@rniwa - should this be RESOLVED LATER? or this path is abandoned? Thanks!
Ryosuke Niwa
Yeah, this is Later at this point.