Bug 60828
| Summary: | Mismatched feature guards for WebChromeClient::fullScreenRendererChanged in WebKit/mac | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | mitz |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | eric.carlson, fred.wang, jer.noble |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 276855 | ||
mitz
The implementation of WebChromeClient::fullScreenRendererChanged() is guarded by #if ENABLE(FULLSCREEN_API) in WebChromeClient.mm, but the declaration in WebChromeClient.h is (incorrectly, I think) guarded by #if ENABLE(VIDEO).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frédéric Wang Nélar
I checked
https://searchfox.org/wubkat/source/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
https://searchfox.org/wubkat/source/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
and fullScreenRendererChanged is no longer a thing. The other "fullscreen" matches seem to correctly use VIDEO_PRESENTATION_MODE and FULLSCREEN_API guards.