Bug 276884
| Summary: | Remove Quirk 'shouldDisableElementFullscreenQuirk' from twitter.com | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | fred.wang, karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | GoodFirstBug, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 206854 | ||
Ahmad Saleem
See https://searchfox.org/wubkat/rev/38fb2ecadd89df8d6d7114cc2b030188d744aeb0/Source/WebCore/page/Quirks.cpp#415
It was added by following commit: https://commits.webkit.org/274117@main in bug 268634, where the precursor was the 'media controls' show up as small when in fullscreen.
1. Compile WebKit Opensource with removal of quirk
2. Go to test page via iOS simulator - https://ftw.usatoday.com/2024/01/lamar-jackson-cj-stroud-micd-up-ravens-texans
2. See if the embedded video on fullscreen does not show any issue (small icons etc.)
Expected result:
- No small icon issue
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/132725236>
Frédéric Wang Nélar
This was actually added in https://commits.webkit.org/273519@main
Now it seems this is handled by a yaml file,
https://searchfox.org/wubkat/rev/19ca701af784c4a231699ba99f5af78f514c4456/Source/WebCore/page/QuirkBehaviors.yaml#474
But I don't see how to know to which domain this is actually applying.
Frédéric Wang Nélar
It seems it's only enabled here:
https://searchfox.org/wubkat/rev/19ca701af784c4a231699ba99f5af78f514c4456/Source/WebCore/page/Quirks.cpp#1306
https://searchfox.org/wubkat/source/Source/WebCore/page/QuirkTable.cpp does not seem to contain any case for shouldDisableElementFullscreenQuirk