Bug 190929
| Summary: | BytecodeGenerator should not force op_get_by_val to be wide within IndexedForInContext | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tadeu Zagallo <tzagallo> |
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ysuzuki |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tadeu Zagallo
As part of https://bugs.webkit.org/show_bug.cgi?id=187373, when emitting an op_get_by_bal within an IndexedForInContext we force it to be emitted as a wide instruction since we might need to patch the instruction later and we want to guarantee that the alternative value fits in the instruction stream. However, we know the only value that we might use to patch the instruction ahead of time, so we could do do a Fits::check to see if it would fit in a narrow instruction and only force it to be wide otherwise.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yusuke Suzuki
Right! We should do this :)
Yusuke Suzuki
I'll do this as a part of bug 197979.
*** This bug has been marked as a duplicate of bug 197979 ***