Bug 189380

Summary: Improper speculation type for Math.pow(NaN, 0) in Abstract Interpreter
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Michael Saboff 2018-09-06 15:52:58 PDT 
Given that Math.pow(NaN, 0) gives the result of 1, the computed SpeculatedType for ArithPow(NaN, non-NaN) should include Double values.
Comment 1 Michael Saboff 2018-09-06 15:53:24 PDT 
<rdar://problem/42908665>
Comment 2 Michael Saboff 2018-09-06 16:00:21 PDT 
Created attachment 349086 [details]
Patch
Comment 3 Saam Barati 2018-09-06 16:18:30 PDT 
Comment on attachment 349086 [details]
Patch

Let's keep an eye on perf bots after this to ensure this doesn't hurt perf anywhere
Comment 4 Michael Saboff 2018-09-06 16:19:25 PDT 
(In reply to Saam Barati from comment #3)
> Comment on attachment 349086 [details]
> Patch
> 
> Let's keep an eye on perf bots after this to ensure this doesn't hurt perf
> anywhere

Good idea.
Comment 5 WebKit Commit Bot 2018-09-06 16:44:57 PDT 
Comment on attachment 349086 [details]
Patch

Clearing flags on attachment: 349086

Committed r235765: <https://trac.webkit.org/changeset/235765>
Comment 6 WebKit Commit Bot 2018-09-06 16:44:58 PDT 
All reviewed patches have been landed.  Closing bug.