| Summary: | Move regress-189185.js under JSTests/wasm. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dominik Inführ <dominik.infuehr> | ||||||||
| Component: | New Bugs | Assignee: | Mark Lam <mark.lam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, realdawei, saam, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=189312 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dominik Inführ
2018-09-06 07:33:13 PDT
Created attachment 349022 [details]
Patch
Created attachment 349023 [details]
Patch
Comment on attachment 349023 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349023&action=review > JSTests/stress/regress-189185.js:1 > +//@ skip if !isWebAssemblyEnabled Why not move this test into the Wasm test directory? Comment on attachment 349023 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349023&action=review >> JSTests/stress/regress-189185.js:1 >> +//@ skip if !isWebAssemblyEnabled > > Why not move this test into the Wasm test directory? I agree with Saam. I should have put this test in JSTests/wasm directory. I just wasn't aware of that option at the time. Let's move the test there instead. Thanks. Since Dominik hasn't responded yet, and this issue seems to be creating problems with some of our internal testing as well, I'll go ahead and implement the fix. Created attachment 349048 [details]
patch for landing.
Comment on attachment 349048 [details] patch for landing. Rejecting attachment 349048 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 349048, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/JSTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/9117011 Landed in r235751: <http://trac.webkit.org/r235751>. Thanks for fixing that! |