| Summary: | [CMake] Make TestWebKitAPI dependencies explicit | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
| Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, annulen, commit-queue, ews-watchlist, Hironori.Fujii, mcatanzaro, webkit-bug-importer | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Don Olmstead
2018-09-04 16:24:29 PDT
Created attachment 348867 [details]
Patch
Attachment 348867 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/CMakeLists.txt:19: Alphabetical sorting problem. "JavaScriptCoreForwardingHeaders" should be before "WTFForwardingHeaders". [list/order] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 348872 [details]
Patch
I fixed this issue in Bug 184441. How can you reproduce? (In reply to Fujii Hironori from comment #4) > I fixed this issue in Bug 184441. > How can you reproduce? Have an empty WebKitBuild. build-webkit --generate-project-only cd WebKitBuild/Release ninja TestWTF Or create a visual studio build and try and build TestWTF first. Comment on attachment 348872 [details]
Patch
You are right. I fixed a problem only for GTK and WPE. This patch looks good to me.
(In reply to Fujii Hironori from comment #6) > Comment on attachment 348872 [details] > Patch > > You are right. I fixed a problem only for GTK and WPE. This patch looks good > to me. Thanks! This should make it so TestWTF never fails to compile due to missing headers. Comment on attachment 348872 [details] Patch Clearing flags on attachment: 348872 Committed r235653: <https://trac.webkit.org/changeset/235653> All reviewed patches have been landed. Closing bug. |