| Summary: | Move replaceTrack logic to LibWebRTCPeerConnectionBackend | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | alex, commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2018-09-04 16:23:04 PDT
Created attachment 348866 [details]
Patch
Created attachment 348926 [details]
Patch
Comment on attachment 348926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348926&action=review > Source/WebCore/ChangeLog:9 > + This allows maing the logic easier to understand. Nit: "This allows maing the logic" -> "This makes the logic" > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:412 > +static inline bool tryUpdatingTrackSource(MediaStreamTrack& currentTrack, MediaStreamTrack* newTrack, const Vector<Source>& sources) It doesn't look like newTrack can be NULL, can you make it a MediaStreamTrack& ? Created attachment 348938 [details]
Patch for landing
Comment on attachment 348938 [details] Patch for landing Clearing flags on attachment: 348938 Committed r235682: <https://trac.webkit.org/changeset/235682> All reviewed patches have been landed. Closing bug. |