| Summary: | Make LibWebRTCRtpSenderBackend own its libwebrtc RTP sender backend | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2018-09-04 13:01:37 PDT
Created attachment 348857 [details]
Patch
Comment on attachment 348857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348857&action=review > Source/WebCore/ChangeLog:8 > + Previously, the libwebrtc sender were owned in LibWebRTCMediaEndpoint. Nit: sender -> senders > Source/WebCore/ChangeLog:9 > + This patch makes them owned by LibWebRTCRtpSenderBackend. Nit: makes them owned by -> makes them be owned by > Source/WebCore/ChangeLog:11 > + This will help simplifying the implementation of RTCRtpSender::replaceTrack. Nit: simplifying -> simplify > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:258 > + if (m_peerConnectionBackend.shouldOfferAllowToReceive("audio")) Nit: "audio" -> "audio"_s > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:260 > + if (m_peerConnectionBackend.shouldOfferAllowToReceive("video")) Nit: "video" -> "video"_s Created attachment 348870 [details]
Patch for landing
Comment on attachment 348870 [details] Patch for landing Clearing flags on attachment: 348870 Committed r235649: <https://trac.webkit.org/changeset/235649> All reviewed patches have been landed. Closing bug. |