| Summary: | slotchange-event-bubbling.html fails in Chrome & Firefox | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, ggaren, koivisto, lforschler, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 189144 | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2018-08-30 21:38:37 PDT
Created attachment 348600 [details]
Fixes the test
Comment on attachment 348600 [details] Fixes the test View in context: https://bugs.webkit.org/attachment.cgi?id=348600&action=review > LayoutTests/ChangeLog:8 > + slotchange event is supposed to fire when a slot element is inserted and there are assinged nodes. Typo: assinged > LayoutTests/ChangeLog:10 > + Firefox and Chrome implements this behavior and fails this test since the test doesn't let microstask Typo: implements -> implement / fails -> fail > LayoutTests/ChangeLog:13 > + Fixed the test by manually waiting for the current microtask queue is emptied after constructing is emptied -> to be emptied? (In reply to Chris Dumez from comment #2) > Comment on attachment 348600 [details] > Fixes the test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348600&action=review > > > LayoutTests/ChangeLog:8 > > + slotchange event is supposed to fire when a slot element is inserted and there are assinged nodes. > > Typo: assinged Fixed. > > LayoutTests/ChangeLog:10 > > + Firefox and Chrome implements this behavior and fails this test since the test doesn't let microstask > > Typo: implements -> implement / fails -> fail Fixed. > > LayoutTests/ChangeLog:13 > > + Fixed the test by manually waiting for the current microtask queue is emptied after constructing > > is emptied -> to be emptied? Fixed. Committed r235568: <https://trac.webkit.org/changeset/235568> |